Repository navigation
fix(io): report what a compio file round sent before it failed - #161
Merged
Merged
Conversation
On Linux, a compio `send_file` round splices up to a pipe's capacity from the file into a pipe, then drains the pipe into the socket. An error while draining was returned as the round's result even when part of the pipe had already reached the socket, so the caller was told nothing went out. `send_file_all` retries `Interrupted` at the same offset, which would send those bytes a second time. A round that fails after draining part of its pipe now reports the drained bytes, as a write does, drops the pipe with whatever it still holds, and leaves the error to the next call. Refs #159
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file round on compio that failed after draining part of its pipe into the socket returned the error, so
send_file_allcould resend bytes already sent after anInterrupted. It now returns what it drained and drops the pipe; the next call reports the error. The new Linux test fills a minimum-size socket buffer, resets the peer mid-round and checks the round reports partial progress and the next call fails; it fails without the fix.Closes #160